From 0a1c018a02cfdb1cb7dc6dc0d14b29f87bce7c69 Mon Sep 17 00:00:00 2001 From: Gavin MacGregor Date: Tue, 11 Feb 2025 20:48:05 +0000 Subject: [PATCH] Remove unused and incorrect subclass copy constructor --- src/qteletextdecoder/levelonepage.cpp | 18 ------------------ src/qteletextdecoder/levelonepage.h | 2 -- 2 files changed, 20 deletions(-) diff --git a/src/qteletextdecoder/levelonepage.cpp b/src/qteletextdecoder/levelonepage.cpp index f1c6d2e..414bc9d 100644 --- a/src/qteletextdecoder/levelonepage.cpp +++ b/src/qteletextdecoder/levelonepage.cpp @@ -33,24 +33,6 @@ LevelOnePage::LevelOnePage() clearPage(); } -// BUG this copy constructor isn't used? Parameter should be LevelOnePage -LevelOnePage::LevelOnePage(const PageBase &other) -{ - m_enhancements.reserve(maxEnhancements()); - clearPage(); - - for (int y=0; y<26; y++) - if (other.packetExists(y)) - setPacket(y, other.packet(y)); - for (int y=26; y<29; y++) - for (int d=0; d<16; d++) - if (other.packetExists(y, d)) - setPacket(y, d, other.packet(y, d)); - - for (int b=PageBase::C4ErasePage; b<=PageBase::C14NOS; b++) - setControlBit(b, other.controlBit(b)); -} - // So far we only call clearPage() once, within the constructor void LevelOnePage::clearPage() { diff --git a/src/qteletextdecoder/levelonepage.h b/src/qteletextdecoder/levelonepage.h index f2c40f8..3a283f8 100644 --- a/src/qteletextdecoder/levelonepage.h +++ b/src/qteletextdecoder/levelonepage.h @@ -36,8 +36,6 @@ public: enum CycleTypeEnum { CTcycles, CTseconds }; LevelOnePage(); - // BUG this copy constructor isn't used? Parameter should be LevelOnePage - LevelOnePage(const PageBase &other); bool isEmpty() const override;