daniel/QTeletextMaker
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add missing optimisation when deleting triplet

Browse Source
This commit is contained in:
G.K.MacGregor
2021-09-09 17:18:15 +01:00
parent 64943f01c5
commit b921d14dbf
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
x26commands.cpp
View File

@@ -127,13 +127,19 @@ DeleteTripletCommand::DeleteTripletCommand(TeletextDocument *teletextDocument, X
void DeleteTripletCommand::redo() void DeleteTripletCommand::redo()
{ {
m_teletextDocument->emit aboutToChangeSubPage(); bool changingSubPage = (m_teletextDocument->currentSubPageIndex() != m_subPageIndex);
m_teletextDocument->selectSubPageIndex(m_subPageIndex);
if (changingSubPage) {
m_teletextDocument->emit aboutToChangeSubPage();
m_teletextDocument->selectSubPageIndex(m_subPageIndex);
} else
m_x26Model->beginRemoveRows(QModelIndex(), m_row, m_row+m_count-1);
m_x26Model->beginRemoveRows(QModelIndex(), m_row, m_row+m_count-1);
for (int i=0; i<m_count; i++) for (int i=0; i<m_count; i++)
m_teletextDocument->currentSubPage()->enhancements()->removeAt(m_row); m_teletextDocument->currentSubPage()->enhancements()->removeAt(m_row);
m_x26Model->endRemoveRows();
if (!changingSubPage)
m_x26Model->endRemoveRows();
// Preserve pointers to local object definitions that have moved // Preserve pointers to local object definitions that have moved
for (int i=0; i<m_teletextDocument->currentSubPage()->enhancements()->size(); i++) { for (int i=0; i<m_teletextDocument->currentSubPage()->enhancements()->size(); i++) {
@@ -146,7 +152,10 @@ void DeleteTripletCommand::redo()
} }
} }
m_teletextDocument->emit subPageSelected(); if (changingSubPage)
m_teletextDocument->emit subPageSelected();
else
m_teletextDocument->emit refreshNeeded();
} }
void DeleteTripletCommand::undo() void DeleteTripletCommand::undo()