daniel/QTeletextMaker
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused and incorrect subclass copy constructor

Browse Source
This commit is contained in:
Gavin MacGregor
2025-02-11 20:48:05 +00:00
parent 4024efaf01
commit 0a1c018a02
2 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/qteletextdecoder/levelonepage.cpp
View File

@@ -33,24 +33,6 @@ LevelOnePage::LevelOnePage()
clearPage();
}
// BUG this copy constructor isn't used? Parameter should be LevelOnePage
LevelOnePage::LevelOnePage(const PageBase &other)
{
m_enhancements.reserve(maxEnhancements());
clearPage();
for (int y=0; y<26; y++)
if (other.packetExists(y))
setPacket(y, other.packet(y));
for (int y=26; y<29; y++)
for (int d=0; d<16; d++)
if (other.packetExists(y, d))
setPacket(y, d, other.packet(y, d));
for (int b=PageBase::C4ErasePage; b<=PageBase::C14NOS; b++)
setControlBit(b, other.controlBit(b));
}
// So far we only call clearPage() once, within the constructor
void LevelOnePage::clearPage()
{

2
src/qteletextdecoder/levelonepage.h
View File

@@ -36,8 +36,6 @@ public:
enum CycleTypeEnum { CTcycles, CTseconds };
LevelOnePage();
// BUG this copy constructor isn't used? Parameter should be LevelOnePage
LevelOnePage(const PageBase &other);
bool isEmpty() const override;